Xfennec wrote:
variable names should follow the usual raydium naming style (__global in common.h and raydium_camera_.... names) or (better I think) declared in the function as static.
Of course, this is just an idea. It has to be cleaned.
Quote:
the function should use directly keyboard, not joystick emulation (raydium_key[GLUT_KEY_UP] and so on ...)
Why? ...I only wanted to allow joystick users to move also with it. Using direct keys will remove the ability to use joystick? And i think this function is focus to developers testing, it won't be used in the 99% of the final applications, so it doesn't matter, i think, if it has a few "extras". right?
Quote:
a camera function is not supposed to clear the framebuffer
Not sure... again, why? Anyway i think putting in the main code a clear function is not so bad, so ok. But i'm not sure which is the reason.
Quote:
then the function name should be something like void raydium_camera_mouselook(void) I think.
Mmm, that name don't show the possibility of move, just of look around with the mouse.
Maybe raydium_camera_auto() or raydium_camera_fps() or raydium_camera_... i'm not too imaginative right now... more ideas?